Skip to content

Bugfix/floating and reset - #60

Merged
eyck merged 8 commits into
mainfrom
bugfix/floating_and_reset
Sep 28, 2026
Merged

eyck merged 8 commits into
mainfrom
bugfix/floating_and_reset

Conversation

@EAlexJ

@EAlexJ EAlexJ commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

This PR now contains both branches, bugfix/reset and bugfix/floating_point_instructions

The merging was a bit messy.

@EAlexJ

EAlexJ commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

After this is merged, the two other branches may be deleted

eyck
eyck previously requested changes Sep 24, 2026

@eyck eyck left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If order of include is important, you should use clang-formnat pragmas. Otherwise it will be changed whenever clang-format is run ( 4bae3b8 )

@EAlexJ

EAlexJ commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor Author

Clang format should be off for the file(s) anyways,
the commit you referenced just enforces the template

@eyck
eyck dismissed their stale review September 28, 2026 06:11

Already implemented

@eyck eyck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyck
eyck merged commit 2ad3223 into main Sep 28, 2026
6 checks passed
@eyck
eyck deleted the bugfix/floating_and_reset branch September 28, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants